Skip to content

config: Android: 16 KB page size #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ajaysehwal wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

config: Android: 16 KB page size #3565

ajaysehwal wants to merge 2 commits into from

Conversation

@ajaysehwal
Copy link
Contributor

@ajaysehwal ajaysehwal commented Jan 22, 2026 •
edited
Loading

Description

Relates to issue: ZEUS-3293

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@ajaysehwal ajaysehwal marked this pull request as draft January 22, 2026 06:12
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Hello @ajaysehwal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Android application's compatibility and stability, particularly for devices utilizing 16KB page sizes. It streamlines the build process by adjusting native library handling and introduces protective measures for third-party modules that rely on native code, preventing potential crashes. Furthermore, a new diagnostic tool is included to assist in verifying the alignment of native libraries, reinforcing the project's commitment to robust Android development practices.

Highlights

  • Android 16KB Page Size Compliance: The Android build configuration has been updated to ensure compliance with 16KB page sizes, which is crucial for performance and compatibility on modern Android devices. This includes disabling legacy JNI packaging and setting android:extractNativeLibs to false.
  • Native Library Alignment Verification: A new shell script, check_elf_alignment.sh, has been added to the project. This script allows developers to verify the ELF alignment of shared libraries within APKs or directories, helping to identify and address potential issues related to 16KB page size requirements.
  • Robustness for Third-Party Native Modules: Patches have been introduced for react-native-tor and react-native-vision-camera to gracefully handle scenarios where their native libraries might not be 16KB-aligned or fail to load. This prevents application crashes by disabling the respective modules if their native components are unavailable, improving overall application stability.
  • NDK Version Update: The Android NDK version has been updated to 28.0.13004108, ensuring the project uses a more recent version of the Native Development Kit.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the requirement for 16KB page-size compliance on Android. The changes to the Gradle configuration, Android Manifest, and NDK version are all appropriate and well-justified with comments. The strategy of patching dependencies like react-native-tor and react-native-vision-camera to gracefully handle potential native library loading failures is excellent, as it enhances the app's resilience. The inclusion of the check_elf_alignment.sh script is a commendable addition for verifying the correctness of these changes. My review includes one suggestion to further improve the robustness of this new verification script.

android/check_elf_alignment.sh
@@ -0,0 +1,113 @@
#!/bin/bash
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To make this script more robust, I recommend adding set -euo pipefail at the beginning.

  • set -e: Exits the script immediately if any command fails. This would prevent the script from providing a misleading 'success' message if, for example, the unzip command at line 64 fails.
  • set -u: Treats unset variables as an error, which helps catch typos in variable names.
  • set -o pipefail: Ensures that a pipeline's exit code is the exit code of the rightmost command to exit with a non-zero status, or zero if all commands of the pipeline exit successfully.

This is a standard best practice for writing safer shell scripts.

Suggested change
#!/bin/bash
#!/bin/bash
set -euo pipefail

@ajaysehwal ajaysehwal force-pushed the android-16kb branch 2 times, most recently from 56bdeda to 6cd6e95 Compare January 22, 2026 06:19
@kaloudis kaloudis modified the milestones: v0.12.3, v0.13.0 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ajaysehwal @kaloudis